Add option to specify modifier in the worksheet API #492
Conversation
There was a problem hiding this comment.
The reset-object modifier is specifically implemented for this feature https://scalameta.org/mdoc/docs/modifiers.html#reset-object
The object encoding can cause deadlocks and other difficult-to-debug errors while the class encoding at least fails fast with a recognizeable error message.
Metals can enable the reset-object modifier without changing mdoc.
It seems we always add the Default modifier, so we would need to replace it with ResetObject one. What do you think? Or alternatively, add an option to specify the modifier to the worksheet API. |
|
Right, it looks like worksheet clients can't add modifiers. It should be an easy change to make this configurable, a good place to look at would be here There's another overload for |
tgodzik
force-pushed
the
fix-issues-with-value
branch
from
9659667 to
4f56125
Compare
tgodzik
changed the title
tgodzik
force-pushed
the
fix-issues-with-value
branch
from
4f56125 to
c7958d5
Compare
| | case class Bar(b: Int) extends AnyVal | ||
| |}""".stripMargin, | ||
| "", | ||
| modifier = Some("reset-object") |
There was a problem hiding this comment.
Is it possible to add multiple modifiers?
There was a problem hiding this comment.
It is! Added a test to demonstrate it.
tgodzik
force-pushed
the
fix-issues-with-value
branch
from
c7958d5 to
ce9e47d
Compare
|
Modifier doesn't exists for Scala 3 currently, so we should be fine to wait for #466 |
tgodzik
force-pushed
the
fix-issues-with-value
branch
2 times, most recently
from
5056dcb to
c6807f1
Compare
tgodzik
force-pushed
the
fix-issues-with-value
branch
from
c6807f1 to
61c5c5c
Compare
Related to scalameta/metals#2764